#44685: Several unique units given as start units
Open Date: 2022-05-27 04:41
Last Update: 2022-06-03 00:47
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44685
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44685
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-06-03 00:47 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.0.2
Component: Server
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
Split from https://www.hostedredmine.com/issues/870631 reported by Alexandro Ignatiev.
Several unique units are given when they are requested by the startunits setting.
"The function that gives these units is crole_to_unit_type() in server/gamehand.c: if it fails grant a buildable unit of the role to the player, it just takes the first ruleset's one resorting to get_role_unit() in common/unittype.c, and that function (used elsewhere, don't change) does not care about uniqueness."
get_role_unit() couldn't care about uniqueness even if it wanted - it has no unit list to check the uniqueness within. As for crole_to_unit_type() users, it seems to me that all of them would want the uniqueness check when they give pplayer, or would not care.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44685
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44685