#46266: A function for arbitrary vector requirement s evaluation Open Date: 2022-12-12 23:13 Last Update: 2022-12-14 00:02 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/46266 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46266 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-12-14 00:02 Updated by: ihnatus Comment: A patch working with 3.1 is added. --------------------------------------------------------------------- Ticket Status: Reporter: ihnatus Owner: ihnatus Type: Patches Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.1.0-beta1 Component: General Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: A split from #46046 cazfi "This patch includes a generic mechanism for arbitrary requirement vector evaluation (i.e., substituting is_req_active() with a custom callback)." Could you split that to a separate patch? So that unrelated functionalities would not be tied to acceptance (schedule) of this patch. I didn't look it closely, but noticed that you have parameters with _sz -suffix in their name, but which are not of type size_t. Should they? -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/46266 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46266