#45889: Send initial counter values to client
Open Date: 2022-10-17 20:08
Last Update: 2022-12-09 01:56
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45889
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45889
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-12-09 01:56 Updated by: lachu
Comment:
Reply To cazfi
I think that information should be sent always when the full city packet gets sent for the first time, not only when the client reconnects. I don't think the current implementation works, e.g., when one conquers an enemy city (well, we only have the "owned" counter at the moment, and that's zeroed at conquest anyway, but in the general case the new owner should get correct counter values). Correct me if that gets handled somehow.
0001-Send-city-counter-updates-to-client.patch(5KB)
Not done yet - send counter value when city transfer
You are right. in srv_main.c we send only value, when counter change, so on end of each turn. We must also send value to new owner (and observers), when city owner's changed.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: 3.2.0
Component: General
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
City counter value updates are sent to client by #45429, but we will need to send also initial values, e.g., when a client reconnects, or game has been loaded from a saved game. Basically when ever full city info gets sent to the client for the first time (note, that if it makes implementation easier; it should be ok to "send" them to the delta protocol layer unconditionally when ever full city info gets sent. Delta protocol would notice itself if there's nothing to update/send)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45889
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45889