#44872: Don't record that barbarians execute ambassadors
Open Date: 2022-06-20 01:06
Last Update: 2022-12-04 20:47
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44872
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44872
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-12-04 20:47 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
* Component Update from General to Server
Comment:
Reply To cazfi
Reply To ihnatus
We should make it clear from help and code comments (server/diplomats.c)
Is there misleading help / documentation currently? Function header for diplomat_embassy() is the only place where I saw that mentioned.
So that header is the only thing this patch touches.
---------------------------------------------------------------------
Ticket Status:
Reporter: ihnatus
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.5
Component: Server
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
They don't do it since v.2.6 already. You can (potentially) establish an embassy to a player with "NoDiplomacy" effect, you just can't meet. So ULR_EXECUTED is unused except maybe by a script.
We should make it clear from help and code comments (server/diplomats.c) that barbarians won't execute the diplomat. We might bring back the "oh, I forgot I can't do it to barbarians!" gameplay with a script callback if we have a way to make AI diplomats not fumble this way too often.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44872
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44872