#46136: Failing "15 > pos->ref_count" assert Open Date: 2022-11-28 15:22 Last Update: 2022-12-01 07:16 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/46136 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46136 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-12-01 07:16 Updated by: cazfi Comment: Reply To cazfi 2) pf_fuel_pos_replace() comments (esp. function header) should be updated -> #46149 --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Bugs Status: Open Priority: 5 - Medium MileStone: (None) Component: General Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: I've got a pf_fuel_pos_ref() assert against too big ref count failing. This is with an AI caravan traveling with a UTYF_COAST boat, i.e., combination of amphibious (land unit + sea unit) path finding and fuel path finding. I'm not convinced that the assert is right. It seems to consider only the fact that one can enter the tile from 8 different directions (neighboring tiles) max. But won't also the refuel points count here? One can came from the same direction but with different refuel history. Of course the assert is right in that the 4 bit field can't hold bigger values than 15 -> maybe we need to make that wider. OTOH amphibious PF makes some move cost multiplication magic that fuel path finding may not be completely compatible with. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/46136 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46136