Commit: f405494f214315091fb0864827b07b5e6f12ee84 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: f405494f214315091fb0864827b07b5e6f12ee84 (tree)
• Zeit: 2020-07-02 21:53:07
• Autor: Alex Coplan <alex.coplan@arm....>
• Commiter: Alex Coplan

Log Message

aarch64: Fix segfault on unicode symbols

This patch fixes a segfault which occurs when the AArch64 backend parses
a symbol operand that begins with a register name and ends with a
unicode byte (byte value > 127).

For example, the following input causes the crash:

x0é: udf x0é

gas/ChangeLog:

2020-07-02 Alex Coplan <[e-mail]>

* config/tc-aarch64.c (reg_name_p): Fix cast so that we don't
segfault on negative chars.
* testsuite/gas/aarch64/reglike-label-unicode-segv.d: New test.
* testsuite/gas/aarch64/reglike-label-unicode-segv.s: Input.

Ändern Zusammenfassung

• modified: gas/ChangeLog
• modified: gas/config/tc-aarch64.c
• add: gas/testsuite/gas/aarch64/reglike-label-unicode-segv.d
• add: gas/testsuite/gas/aarch64/reglike-label-unicode-segv.s

Diff

--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,10 @@
[phone]  Alex Coplan  <[e-mail]>
+
+	* config/tc-aarch64.c (reg_name_p): Fix cast so that we don't
+	segfault on negative chars.
+	* testsuite/gas/aarch64/reglike-label-unicode-segv.d: New test.
+	* testsuite/gas/aarch64/reglike-label-unicode-segv.s: Input.
+
 2020-07-02  Nick Clifton  <[e-mail]>
 
 	PR 26028

--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -2190,7 +2190,7 @@ reg_name_p (char *str, aarch64_reg_type reg_type)
     return FALSE;
 
   skip_whitespace (str);
-  if (*str == ',' || is_end_of_line[(unsigned int) *str])
+  if (*str == ',' || is_end_of_line[(unsigned char) *str])
     return TRUE;
 
   return FALSE;

--- /dev/null
+++ b/gas/testsuite/gas/aarch64/reglike-label-unicode-segv.d
@@ -0,0 +1,8 @@
+#objdump: -dr
+
+.*:     file format .*
+
+Disassembly of section \.text:
+
+0+ <x0é>:
+.*:	00000000 	udf	#0

--- /dev/null
+++ b/gas/testsuite/gas/aarch64/reglike-label-unicode-segv.s
@@ -0,0 +1,2 @@
+x0é:
+udf x0é