Commit: 3730a015c05cde8d151f94bef20e43ea2bf96ccc - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: 3730a015c05cde8d151f94bef20e43ea2bf96ccc (tree)
• Zeit: 2020-05-18 17:19:31
• Autor: Alan Modra <amodra@gmai...>
• Commiter: Alan Modra

Log Message

Re: Fix tight loop on recursively-defined symbols

sy_resolving ought to not be set for a struct local_symbol, but it is
apparent from local_symbol_make that the field is not initialised.

* symbols.c (resolve_symbol_value): Invoke LOCAL_SYMBOL_CHECK
before looking at add_symbol->sy_flags.sy_resolving.

(cherry picked from commit d402189f2faa0aaa9fb8ad4669fdf0059946cd8a)

Ändern Zusammenfassung

• modified: gas/ChangeLog
• modified: gas/symbols.c

Diff

--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
[phone]  Alan Modra  <[e-mail]>
+
+	* symbols.c (resolve_symbol_value): Invoke LOCAL_SYMBOL_CHECK
+	before looking at add_symbol->sy_flags.
+
 2020-05-15  Alan Modra  <[e-mail]>
 	    Alex Coplan  <[e-mail]>
 

--- a/gas/symbols.c
+++ b/gas/symbols.c
@@ -1387,6 +1387,7 @@ resolve_symbol_value (symbolS *symp)
 
 	  /* Don't leave symbol loops.  */
 	  if (finalize_syms
+	      && !LOCAL_SYMBOL_CHECK (add_symbol)
 	      && add_symbol->sy_flags.sy_resolving)
 	    break;