[Uclinux-h8-devel] [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread()

Zurück zum Archiv-Index
Kees Cook keesc****@chrom*****
2020年 6月 23日 (火) 09:46:56 JST

On Tue, Jun 23, 2020 at 01:43:26AM +0200, Christian Brauner wrote:
> Now that HAVE_COPY_THREAD_TLS has been removed, rename copy_thread_tls()
> back simply copy_thread(). It's a simpler name, and doesn't imply that only
> tls is copied here. This finishes an outstanding chunk of internal process
> creation work since we've added clone3().
> [...]
> -copy_thread_tls(unsigned long clone_flags, unsigned long user_stack_base,
> +copy_thread(unsigned long clone_flags, unsigned long user_stack_base,
>  		    unsigned long user_stack_size, struct task_struct *p,
>  		    unsigned long tls)

Maybe clean up the arg indentation too? I'm not sure how strongly people
feel about that, but I think it'd be nice.

Either way:

Reviewed-by: Kees Cook <keesc****@chrom*****>

Kees Cook

Uclinux-h8-devel メーリングリストの案内
Zurück zum Archiv-Index