Ticket #18740

Check return codes everywhere

Eröffnet am: 2009-09-17 01:58 Letztes Update: 2009-10-06 22:29

Auswertung:
Verantwortlicher:
(Keine)
Status:
Offen
Komponente:
(Keine)
Meilenstein:
(Keine)
Priorität:
3
Schweregrad:
5 - Mittel
Lösung:
Postponed
Datei:
Keine
Vote
Score: 0
No votes
0.0% (0/0)
0.0% (0/0)

Details

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "WriteFile" like in the function "CommentLogToFile" and from "GetModuleFileName" in the function "GetUILanguageFile"?

Ticket-Verlauf (3/7 Historien)

2009-09-17 01:58 Aktualisiert von: elfring
  • New Ticket "Check return codes everywhere" created
2009-09-26 11:56 Aktualisiert von: maya
Kommentar

How do you think a user hope which behavior?

(1) check the error and pop up MessageBox(modal), interrupt user operation.
(2) check the error and not notify to user.

2009-09-26 18:56 Aktualisiert von: elfring
Kommentar

Situations might happen where users can not be notified about the unexpected "thing" by a message box.

Usual software design options are described in the article "Exception Handling Alternatives" by Detlef Vollmann.

I suggest to avoid unchecked function calls. Would you like to detect every error situation as early as possible?

2009-09-29 12:18 Aktualisiert von: maya
Kommentar

I read your suggestion as "detect every error at every function call."

It is in the right. And it takes labor and time to check them.

2009-09-29 19:05 Aktualisiert von: elfring
Kommentar

You do not need to make assumptions about error situations. Please check all error codes. Otherwise, it might not be noticed if anything unexpected went wrong.

Would you like to reduce the efforts for error code checking by an exception class hierarchy?

2009-10-06 22:28 Aktualisiert von: maya
  • Priorität Update from 5 - Mittel to 3
  • Typ Update from Fehler to Funktionsanfragen
2009-10-06 22:29 Aktualisiert von: maya
  • Lösung Update from Keine to Postponed

Dateianhangliste

Keine Anhänge

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden