• R/O
  • HTTP
  • SSH
  • HTTPS

linux-2.4.36: Commit

2.4.36-stable kernel tree


Commit MetaInfo

Revision61592d6c077f418fe7b4986b75deecf79e9fb7fd (tree)
Zeit2008-09-07 18:29:26
AutorWilly Tarreau <w@1wt....>
CommiterWilly Tarreau

Log Message

sound: fix warning due to incorrect error code checking in ad1889

ad1889.c: In function ad1889_ac97_init':
ad1889.c:857: warning: comparison is always false due to limited range of data type

This is caused by a short being compared against 0xFFFFFF while
0xFFFF was indeed expected. The missing device would just never
have been detected.

Signed-off-by: Willy Tarreau <w@1wt.eu>

Ändern Zusammenfassung

Diff

--- a/drivers/sound/ad1889.c
+++ b/drivers/sound/ad1889.c
@@ -854,7 +854,7 @@ static int ad1889_ac97_init(ad1889_dev_t *dev, int id)
854854 }
855855
856856 eid = ad1889_codec_read(ac97, AC97_EXTENDED_ID);
857- if (eid == 0xffffff) {
857+ if (eid == 0xffff) {
858858 printk(KERN_WARNING DEVNAME ": no codec attached?\n");
859859 goto out_free;
860860 }
Show on old repository browser