• R/O
  • HTTP
  • SSH
  • HTTPS

linux-2.4.36: Commit

2.4.36-stable kernel tree


Commit MetaInfo

Revision1f4142d8789d22527cc140f03f9cc8f6f8caa117 (tree)
Zeit2008-10-20 06:11:40
AutorArjan van de Ven <arjan@linu...>
CommiterWilly Tarreau

Log Message

security: avoid calling a NULL function pointer in drivers/video/tvaudio.c

NULL function pointers are very bad security wise. This one got caught by
kerneloops.org quite a few times, so it's happening in the field....

Fix is simple, check the function pointer for NULL, like 6 other places
in the same function are already doing.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
[2.6 commit: 5ba2f67afb02c5302b2898949ed6fc3b3d37dcf1]
Signed-off-by: Willy Tarreau <w@1wt.eu>

Ändern Zusammenfassung

Diff

--- a/drivers/media/video/tvaudio.c
+++ b/drivers/media/video/tvaudio.c
@@ -1635,7 +1635,7 @@ static int chip_command(struct i2c_client *client,
16351635 case VIDIOCSFREQ:
16361636 {
16371637 chip->mode = 0; /* automatic */
1638- if (desc->checkmode) {
1638+ if (desc->checkmode && desc->setmode) {
16391639 desc->setmode(chip,VIDEO_SOUND_MONO);
16401640 if (chip->prevmode != VIDEO_SOUND_MONO)
16411641 chip->prevmode = -1; /* reset previous mode */
Show on old repository browser