Ticket #39560

English version crash from spell_RF6_HEAL() in mspells4.c

Eröffnet am: 2019-09-10 17:11 Letztes Update: 2021-01-01 22:36

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
(Keine)
Priorität:
3
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
2

Details

In the English version running on Mac OS X, a combat with a Moon beast and a nearby orc shaman triggered a crash. The relevant part of the call stack at the point of the crash was:

 ...
monspell_message_base(m_idx = 9, t_idx = 0, ... , msg_flag_aux = 0, TARGET_TYPE = 1) mspells4.c line 133
spell_RF6_HEAL(m_idx = 9, t_idx = 0, TARGET_TYPE = 1)  mspells4.c line 1734
monspell_to_player(SPELL_NUM = 162, y = 5, x = 109, m_idx = 9)  mspells4.c line 3499
....

I've attached a patch so that the English messages for that spell and for spell_RF6_HASTE, which appears to have a similar problem, mimic the Japanese version and should avoid the crash. Like the Japanese version, the 4th form of the message isn't taking into account the other participant. Also, the English version isn't attempting to match the gender of the possessive pronoun.

Ticket-Verlauf (3/8 Historien)

2019-09-10 17:11 Aktualisiert von: backwardseric
  • New Ticket "English version crash from spell_RF6_HEAL() in mspells4.c" created
2019-09-11 00:28 Aktualisiert von: deskull
2019-10-02 02:35 Aktualisiert von: backwardseric
Kommentar

Uploaded a revised version of the patch which uses possessive pronouns appropriate for the gender of the monster.

2020-01-21 22:28 Aktualisiert von: hourier
Kommentar

本件修正し、feature/Refactoring-Hourierブランチにてコミットしました。 後ほどマージ願います

2020-01-22 00:39 Aktualisiert von: deskull
  • Status Update from Offen to Geschlossen
Kommentar

マージ行いました。ありがとうございます。

2021-01-01 22:36 Aktualisiert von: deskull

Dateianhangliste

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden