EMERGENCY_VERSION redefinition in autotools builds

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Offen [Owner assigned]
• Komponente: Bootstrap
• Meilenstein: 3.1.1
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Keine
• Datei: 1

Details

Generated version_gen.h might unconditionally redefine EMERGENCY_VERSION. Autotools based builds do it on configure too.

Ticket-Verlauf (3/9 Historien)

2023-06-24 16:54 Aktualisiert von: cazfi

• New Ticket "EMERGENCY_VERSION redefinition in autotools builds" created

2023-06-24 17:22 Aktualisiert von: cazfi

• Meilenstein Update from (Keine) to 3.1.0-beta3 (closed)

Kommentar

More serious side of this: Other parts of the code assume that EMERGENCY_VERSION information is correctly available from fc_config.h, but it's not in case of Meson based builds.

2023-06-24 17:44 Aktualisiert von: cazfi

Kommentar

Reply To cazfi

More serious side of this: Other parts of the code assume that EMERGENCY_VERSION information is correctly available from fc_config.h, but it's not in case of Meson based builds.

This is actually avoided by having meson generated fc_config.h to include version_gen.h.

So, maybe all the issues are currently on autotools side (but fixing those might still require touching meson side too, to not break it)

2023-06-24 18:03 Aktualisiert von: cazfi

• File 0027-Configure-Fix-EMERGENCY_VERSION-redefinition.patch (File ID: 12727) is attached

2023-06-24 18:03 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

2023-06-26 23:16 Aktualisiert von: cazfi

• Lösung Update from Accepted to Keine

Kommentar

This seems to break installer_cross / autotools build quite badly. Have to investigate. Seems like there's a dormant issue that version_gen.h is not generated the way it should. As this fix makes the build to rely more on version_gen.h, those issues unearth.

2023-09-07 04:01 Aktualisiert von: cazfi

• Meilenstein Update from 3.1.0-beta3 (closed) to 3.1.0-beta4 (closed)

2023-12-29 07:00 Aktualisiert von: cazfi

• Meilenstein Update from 3.1.0-beta4 (closed) to 3.1.0 (closed)

2024-03-01 09:42 Aktualisiert von: cazfi

• Meilenstein Update from 3.1.0 (closed) to 3.1.1