sdl2: First create_tech_info() 't1' assignment is a dead one

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: SDL2-client
• Meilenstein: 3.0.7 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 3

Details

As clang analyzer reports, 't1' assignment in create_tech_info() before the while loop is a dead one. It gets overwritten on the first round of the loop. Further, the assignment might cause NULL dereference if there's no sub targets (even index 0 sub target is NULL).

Ticket-Verlauf (3/6 Historien)

2023-03-21 02:59 Aktualisiert von: cazfi

• New Ticket "sdl2: First create_tech_info() 't1' assignment is a dead one" created

2023-03-21 03:15 Aktualisiert von: cazfi

• File 0031-sdl2-Fix-tech-help-NULL-dereference.patch (File ID: 11908) is attached

2023-03-21 03:15 Aktualisiert von: cazfi

• File 0016-sdl2-Fix-tech-help-NULL-dereference.patch (File ID: 11909) is attached

2023-03-21 03:15 Aktualisiert von: cazfi

• File 0004-sdl-2-Fix-tech-help-NULL-dereference.patch (File ID: 11910) is attached

2023-03-21 03:16 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

Kommentar

Attached even S2_6 patch, handling also sdl-client

2023-03-26 17:13 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt