Infinite recursion: found_new_tech() -> choose_tech() -> tech_researched() -> repeat

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: General
• Meilenstein: 3.0.7
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details Antworten

Backtrace of a crashed S3_0 autogame reveals recursive loop of found_new_tech() -> choose_tech() -> tech_researched() -> from the beginning

choose_tech() seems to have 201 (which is A_FUTURE, I think) as a parameter.

Ticket-Verlauf (3/7 Historien)

2023-01-19 01:05 Aktualisiert von: cazfi

• New Ticket "Infinite recursion: found_new_tech() -> choose_tech() -> tech_researched() -> repeat" created

2023-01-19 02:35 Aktualisiert von: cazfi

Kommentar Antworten

This was caused by a local (-> not yet in repo) patch #45115.

A_FUTURE is a tech has it's requirements set to A_NEVER, yet it's supposed to be in game.

2023-01-19 06:43 Aktualisiert von: cazfi

• Meilenstein Update from 3.0.6 (closed) to 3.0.7
• Komponente Update from Server to General

Kommentar Antworten

Reply To cazfi

This was caused by a local (-> not yet in repo) patch #45115.

It's possible that A_FUTURE not being considered valid advance causes some other issues, but those would have been there for a long time, not to be a recent regression. As changing it has significant risk of breaking some caller, let's leave this to the next full cycle.

2023-02-14 13:38 Aktualisiert von: cazfi

• File 0042-valid_advance-Consider-Future-techs-valid-ones.patch (File ID: 11633) is attached

2023-02-14 13:38 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

2023-02-17 13:38 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt

2023-03-20 03:31 Aktualisiert von: cazfi

Kommentar Antworten

Reply To cazfi

As changing it has significant risk of breaking some caller, let's leave this to the next full cycle.

We now have such a breakage in #47574