Ticket #45877

Factor unit_move_data construction from unit_move()

Eröffnet am: 2022-10-16 06:26 Letztes Update: 2023-01-29 02:31

Auswertung:
Verantwortlicher:
(Keine)
Typ:
Status:
Offen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Keine
Datei:
Keine

Details

To be able to resolve things like https://www.hostedredmine.com/issues/736060 we need to be able to construct the unit_move_data before calling unit_move(). First step is to refactor it out from unit_move() to a separate function. Targeting to S3_0 because dependency to fixing bug mentioned earlier.

Ticket-Verlauf (3/4 Historien)

2022-10-16 06:26 Aktualisiert von: cazfi
  • New Ticket "Factor unit_move_data construction from unit_move()" created
2022-10-16 06:35 Aktualisiert von: cazfi
Kommentar

Also have to move out side effect of unit_data() that it actually does the move. Even when we want to collect the data earlier, we don't want unit location to be changed at the same time.

2022-11-28 05:14 Aktualisiert von: cazfi
Kommentar

This turned out to be much more involved change than I expected. At this point it seems clear that it's better to live with the bug in S3_0 than to introduce this change with all the risks of introducing a lot of new bugs.

2023-01-29 02:31 Aktualisiert von: cazfi
Kommentar

Reply To cazfi

Also have to move out side effect of unit_move_data() that it actually does the move.

-> #46614, dependency of this ticket.

Dateianhangliste

Keine Anhänge

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden