Ticket #45716

generate_packets.py: Replace unfill with bit-copy/move

Eröffnet am: 2022-09-25 22:57 Letztes Update: 2022-09-28 22:25

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
1

Details

Part of #43927. The unfill concept introduced in #45222 as a mirror to fill is ultimately misguided; the actual use case is backing up the received key fields while zeroing a packet struct (to initialize the cache), which amounts to temporarily moving those values out of the struct – this is better achieved by bitcopying the data, i.e. a straight assignment (for non-arrays at least). In contrast, fill clones the data, which is not what we want here (and which could cause problems if and when we start to support types that need to be destroyed explicitly).

Ticket-Verlauf (3/4 Historien)

2022-09-25 22:57 Aktualisiert von: alienvalkyrie
  • New Ticket "generate_packets.py: Replace unfill with bit-copy/move" created
2022-09-26 22:04 Aktualisiert von: alienvalkyrie
  • Lösung Update from Keine to Accepted
2022-09-28 22:25 Aktualisiert von: alienvalkyrie
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden