generate_packets.py: make files_equal() compare contents line by line

• Auswertung: alienvalkyrie
• Verantwortlicher: alienvalkyrie
• Typ: Patches
• Status: Geschlossen
• Komponente: Bootstrap
• Meilenstein: 3.2.0
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

Part of #43927. Related to #45186. The files_equal() helper function (which is used by lazy-overwrite) currently loads both input files completely ~> make it use the fact that TextIO objects are iterable to compare them line by line

Ticket-Verlauf (3/4 Historien)

2022-07-22 00:23 Aktualisiert von: alienvalkyrie

• New Ticket "generate_packets.py: make files_equal() compare contents line by line" created

2022-07-22 00:43 Aktualisiert von: alienvalkyrie

• File 0004-generate_packets.py-make-files_equal-compare-lines.patch (File ID: 9895) is attached

2022-07-22 00:46 Aktualisiert von: alienvalkyrie

• Lösung Update from Keine to Accepted

Kommentar

Depends on #45186 (or rather, its parts):

• textual dependency on #45188 (import changes)
• this patch removes the now-unused read_text() function and thus must not be merged before #45189

2022-07-23 19:18 Aktualisiert von: alienvalkyrie

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt