Ticket #45188

generate_packets.py: parse packet and type definitions in one go

Eröffnet am: 2022-07-22 00:12 Letztes Update: 2022-07-23 19:17

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
1

Details

Part of #45186. Make a PacketsDefintion.parse_clean_lines(lines: Iterable[str]) method that parses input line by line in one go, rather than the current approach of doing types first and then going over everything that's left again for the packets.

This will make it so types can no longer be defined anywhere, but must be defined before they're used, and may no longer be defined inside a packet definition.

Ticket-Verlauf (3/4 Historien)

2022-07-22 00:12 Aktualisiert von: alienvalkyrie
  • New Ticket "generate_packets.py: parse packet and type definitions in one go" created
2022-07-22 00:39 Aktualisiert von: alienvalkyrie
  • Lösung Update from Keine to Accepted
  • Details Updated
Kommentar

Note that this causes an edge case where at the very end of the file, an end line can be omitted – explicitly forbidding this would require writing a custom takewhile implementation, which probably isn't worth the hassle.

2022-07-23 19:17 Aktualisiert von: alienvalkyrie
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

Please login to add comment to this ticket » Anmelden