Ticket #45076

Sort out unknown research targets

Eröffnet am: 2022-07-10 04:07 Letztes Update: 2022-10-11 13:01

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
3

Details

Spotted during work on #45068. A comment in common/research.h says: "For enemies, A_UNKNOWN is sent to the client". Actually, if you don't have embassy, you don't get research info and in the memory there is the default A_UNSET value. Also, if you lose embassy data (wonder deprecates, teammate with embassy killed) during client session, then the research info gets frozen in the last known state that is possibly not wanted or should look another way.

Ticket-Verlauf (3/8 Historien)

2022-07-10 04:07 Aktualisiert von: ihnatus
  • New Ticket "Sort out unknown research targets" created
2022-07-15 16:44 Aktualisiert von: cazfi
Kommentar

A good implementation will do changes on network protocol level, don't you think? (Sending full research info packet with dummy values sounds excessive)

Targeting this to block S3_1 npf - doesn't mean we can't make some kind of solution to S3_0 (maybe even with optional network capabilities)

2022-09-28 06:28 Aktualisiert von: cazfi
Kommentar

If someone is about to look at this, note that I have partly written patch for this, but currently waiting for me to get some other things out of the way. You may want to get that instead of writing everything from scratch.

2022-10-06 10:05 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
Kommentar

Targeted both to 3.0.5 and S3_1-npf, but we can have only one target listed.

2022-10-11 13:01 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt
  • Meilenstein Update from S3_1 npf to 3.0.5
Kommentar

Reply To cazfi

Targeted both to 3.0.5 and S3_1-npf, but we can have only one target listed.

Now that it's in (before S3_1-npf), changing documented target to 3.0.5, for the benefit of collecting NEWS for 3.1.0 - will see that this one is NOT a new thing in 3.1.

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden