generate_packets.py: phase out use of vars() in formatting

• Auswertung: alienvalkyrie
• Verantwortlicher: alienvalkyrie
• Typ: Patches
• Status: Geschlossen
• Komponente: Bootstrap
• Meilenstein: 3.2.0
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

Part of #43927. Using vars() makes it impossible for IDEs or static code checking tools to reason about usage of variables. We should replace uses of vars() with a more robust formatting solution.

Since f-strings are only available from Python 3.6 onward, we'll have to fall back on the "...".format(foo = foo, bar = bar) idiom for now.

Ticket-Verlauf (3/5 Historien)

2022-05-13 05:20 Aktualisiert von: alienvalkyrie

• New Ticket "generate_packets.py: phase out use of vars() in formatting" created

2022-05-13 05:31 Aktualisiert von: alienvalkyrie

Kommentar

Variant.get_send() and Variant.get_receive() have their own idiosyncratic formatting mechanisms and will be dealt with separately in #44577

(Edited, 2022-05-13 05:34 Aktualisiert von: alienvalkyrie)

2022-05-13 05:45 Aktualisiert von: alienvalkyrie

• File 0003-generate_packets.py-Phase-out-get_dict-and-vars-in-m.patch (File ID: 9211) is attached

2022-05-13 05:46 Aktualisiert von: alienvalkyrie

• Lösung Update from Keine to Accepted

Kommentar

Depends on #44563 and #44576

2022-05-16 21:19 Aktualisiert von: alienvalkyrie

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt