Ticket #44406

Qt: Shortcuts num_shortcuts wrong

Eröffnet am: 2022-04-17 21:30 Letztes Update: 2022-05-04 12:39

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
1

Details

Qt-client shortcuts.cpp has a "static int num_shortcuts = 57;" which is used at least to tell number of shortcuts to save and load. The value currently isn't same as highest value in 'enum shortcut_id' (nor +1 for considering the value 0) - I'm not yet entirely sure if it should. But I'm sure that it should have been increased when the new shortcut (for toggling Unit Stack Size) was last added, and it was not. So it's certainly wrong, have to just determine how much.

Ticket-Verlauf (3/5 Historien)

2022-04-17 21:30 Aktualisiert von: cazfi
  • New Ticket "Qt: Shortcuts num_shortcuts wrong" created
2022-04-17 23:47 Aktualisiert von: cazfi
Kommentar

Fix for #44407 should go in before this - once we save those shortcuts in the end of the array, we don't want to save (so that they may remain in use forever) a wrong one.

2022-04-23 16:40 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
  • Meilenstein Update from (Keine) to 3.1.0 (closed)
2022-05-04 12:39 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden