Ticket #44386

sanity_check_ruleset_data() needs clearing old compat code?

Eröffnet am: 2022-04-16 00:22 Letztes Update: 2022-05-02 13:54

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
2

Details

sanity_check_ruleset_data() comment about ignore_retired is suspicious: "were retired in Freeciv 3.0."

So is the compat code in question supposed to be in later branches? Sounds like it would allow things that were not legal even in the versions that the compatibility is expected with (3.0 compat in S3_1, 3.1 compat in master)

Ticket-Verlauf (3/6 Historien)

2022-04-16 00:22 Aktualisiert von: cazfi
  • New Ticket "sanity_check_ruleset_data() needs clearing old compat code?" created
2022-04-21 04:26 Aktualisiert von: cazfi
Kommentar

It doesn't really doable to differentiate between what's supposed to be acceptable conflict in a compat mode, and which are not. The current condition at least makes all conflicts illegal outside compat mode.

What should be changed here, is to do full check also in compat mode, if we are in fact loading ruleset of the current freeciv version's format.

2022-04-22 06:32 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
2022-05-02 13:54 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden