Ticket #44383

Saving lua objects by rule_name

Eröffnet am: 2022-04-15 13:10 Letztes Update: 2022-04-26 14:47

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
1

Details

At this point this ticket is mostly a placeholder, but we need to think what to do with saving the lua objects. I don't like the idea of postponing those long-standing issues futher (-> 3.2), so this ticket blocking S3_1-d3f at least prevents us from forgetting about them and going d3f accidentally without resolving the issue.

Ticket-Verlauf (3/7 Historien)

2022-04-15 13:10 Aktualisiert von: cazfi
  • New Ticket "Saving lua objects by rule_name" created
2022-04-15 13:10 Aktualisiert von: cazfi
  • Details Updated
2022-04-16 12:46 Aktualisiert von: cazfi
Kommentar

The question with this is whether we just improve _freeciv_state_dump() a bit in this respect, or should we do the total replacement at this point: http://forum.freeciv.org/f/viewtopic.php?f=14&t=91972#p103950

Quick fix would 1) still be an improvement, and there's no *regression* compared to S3_0. 2) Be the quick solution, to get d3f unblocked.

Yet, I'd hate to postpone the overall fix yet another version.

2022-04-16 13:36 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
Kommentar

I think that attached patch to _freeciv_data_dump() is already a huge improvement. Going by that if nobody objects.

Something similar would be good to get to S3_0 too, but will probably open a completely new ticket about that rather than trying to implement the port in this ticket. The limitations of the lua API might make the implementation more hairy in that branch.

2022-04-24 01:43 Aktualisiert von: cazfi
Kommentar

Reply To cazfi

Something similar would be good to get to S3_0 too, but will probably open a completely new ticket about that

-> #44447

2022-04-26 14:47 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden