Ticket #44309

.mpdl format: Allow baseURL to end to '/'

Eröffnet am: 2022-04-09 21:05 Letztes Update: 2022-04-21 08:06

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
2

Details

Modpack installer forms the final URL by "baseURL + '/' + path". That means that baseURL is not allowed to contain the '/' as it would duplicate, leading to trouble as I just witnessed debugging problems on a modpack that was installed with baseURL "./"

We definitely be smarter about that, and check if baseURL already ends to '/', and not duplicate it in that case.

This should be the case both with paths relative to modpack list, and paths relative to .mpdl.

Ticket-Verlauf (3/5 Historien)

2022-04-09 21:05 Aktualisiert von: cazfi
  • New Ticket ".mpdl format: Allow baseURL to end to '/'" created
2022-04-10 12:52 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
Kommentar

S3_0 (d3f branch) patch just adds warning about the format to README.modpack_installer.

2022-04-21 08:06 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden