Meson: meson_fc_config.h.in without FREECIV_STORAGE_DIR

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: Bootstrap
• Meilenstein: 3.1.0 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

meson.build tries to set FREECIV_STORAGE_DIR both to fc_config.h and freeciv_config.h, but fails silently in case of fc_config.h as meson_fc_config.h.in does not have the stub. I guess nothing currently really relies on the macro being present in fc_config.h, as this has not caused compile errors, but we should still correct the situation.

Ticket-Verlauf (3/5 Historien)

2022-03-27 21:08 Aktualisiert von: cazfi

• New Ticket "Meson: meson_fc_config.h.in without FREECIV_STORAGE_DIR" created

2022-03-27 21:14 Aktualisiert von: cazfi

Kommentar

Reply To cazfi

I guess nothing currently really relies on the macro

On the meson side (unlike autotools) fc_config.h includes more generic freeciv_config.h, so the macro comes to users of fc_config.h that way, and there's no need to set it in both headers.

2022-03-27 21:19 Aktualisiert von: cazfi

• File 0044-Meson-Don-t-try-to-set-FREECIV_STORAGE_DIR-to-fc_con.patch (File ID: 8836) is attached

2022-03-27 21:20 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

2022-04-09 22:55 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt