Ticket #43979

generate_packets.py: generate_stats doesn't work

Eröffnet am: 2022-02-25 09:15 Letztes Update: 2022-03-01 19:58

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
1

Details

The generate_stats option, which, prior to #43938, can only be set by changing the code, and which has never been enabled, doesn't work (crashes with an AttributeError). It can't ever have worked, even in the original version of the script.

Since the option has apparently never been used in its over eighteen years of existing, the question is whether it's worth fixing, or should be removed entirely.

Ticket-Verlauf (3/4 Historien)

2022-02-25 09:15 Aktualisiert von: alienvalkyrie
  • New Ticket "generate_packets.py: generate_stats doesn't work" created
2022-02-26 23:58 Aktualisiert von: alienvalkyrie
  • Verantwortlicher Update from (Keine) to alienvalkyrie
  • Lösung Update from Keine to Accepted
Kommentar

The attached fix is relatively simple and generates compiling code that works as usual without issues. However, because of #43988, the resulting stats generation cannot easily be tested in its natural environment yet.

Update: I tested it with a temporary, ad-hoc fix for #43988, and everything seems to be in order.

(Edited, 2022-02-27 02:26 Aktualisiert von: alienvalkyrie)
2022-03-01 19:58 Aktualisiert von: alienvalkyrie
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden