generate_packets.py: Use pathlib for file path handling
alienvalkyrie alienvalkyrie alienvalkyrie alienvalkyrie In addition to cleaning up parts of the code, this patch finally makes it possible to run the script on Windows without running into issues due to mixed path separators.
Reply To alienvalkyrie
In addition to cleaning up parts of the code, this patch finally makes it possible to run the script on Windows without running into issues due to mixed path separators.
I assume that by "path separators" you mean separator between a directory and its subdirectory, not separator between entire paths like in PATH environment variable and the like.
Is there a risk that this *introduces* mixed dir separators? The build system runs it with parameters given with '/' separator. If it then appends to that with '\' separators, the resulting path will contain both.
alienvalkyrie Reply To cazfi
Reply To alienvalkyrie
In addition to cleaning up parts of the code, this patch finally makes it possible to run the script on Windows without running into issues due to mixed path separators.
I assume that by "path separators" you mean separator between a directory and its subdirectory, not separator between entire paths like in PATH environment variable and the like.
Yes, thank you. "path separators" was the wrong word to use there.
Is there a risk that this *introduces* mixed dir separators? The build system runs it with parameters given with '/' separator. If it then appends to that with '\' separators, the resulting path will contain both.
There is not – that kind of issue is precisely what pathlib is designed to handle. Since Windows file and directory names aren't allowed to contain slashes anyway, those are safely parsed as separating directories (in fact, until the point where a path is given to the OS or otherwise turned into a plain string, I believe slashes are used internally even for Windows paths).
To be sure, I tested the script on both Windows and Linux – on Windows, the verbose log messages (where paths are stringified) have backslashes in them (even where the build system passed paths with slashes, since every path passes through pathlib), but apart from that, everything is identical.
alienvalkyrie)
alienvalkyrie 
Part of #43927. Using pathlib allows for clean, filesystem-agnostic handling of paths.