Ticket #43075

Rename "Firepower1" combat bonus as "MinimalFirepower"

Eröffnet am: 2021-10-19 13:17 Letztes Update: 2021-11-25 17:51

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
2

Details

As we're changing hardcoded firepower of '1' as used by various special cases to a ruleset defined values in #43041, name of combat bonus "FirePower1" is getting misleading. Rename it to "MinimalFirePower".

As part of #43200, this has also been posted to http://forum.freeciv.org/f/viewtopic.php?f=14&t=92036

Ticket-Verlauf (3/9 Historien)

2021-10-19 13:17 Aktualisiert von: cazfi
  • New Ticket "Rename "Firepower1" combat bonus as "MinimalFirepower"" created
2021-11-08 11:54 Aktualisiert von: cazfi
Kommentar

Shorter "MinFirePower" would probably do, without being any more confusing than "MinimalFirePower" (when followed by a value that is *not* the "minimal" firepower but sort of boolean enabling the bonus)

2021-11-09 21:09 Aktualisiert von: cazfi
Kommentar

Reply To cazfi

Shorter "MinFirePower" would probably do, without being any more confusing than "MinimalFirePower" (when followed by a value that is *not* the "minimal" firepower but sort of boolean enabling the bonus)

Maybe "LowFirepower" would be less confusing?

2021-11-13 16:47 Aktualisiert von: cazfi
  • Details Updated
2021-11-13 16:49 Aktualisiert von: cazfi
  • Lösung Update from Keine to Accepted
Kommentar

Attached patches go for "LowFirepower"

2021-11-23 01:35 Aktualisiert von: cazfi
Kommentar

When pushing this, also update S3_1 commit hash that master does CI ruleup tests from.

2021-11-25 17:51 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Accepted to Gefixt

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden