Ticket #42992

Inconsistent code about "Local" range "Good" reqs

Eröffnet am: 2021-10-07 17:30 Letztes Update: 2023-01-31 11:17

Auswertung:
Verantwortlicher:
(Keine)
Typ:
Status:
Offen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Keine
Datei:
Keine

Details

When looking #42944

Additional inconsistency is that is_goods_type_in_range() would accept "Local" range, if the ruleset loading would ever let it through. As currently implemented, it's identical to "City" range, but I guess the idea might have been that it should check if the local tile has a city with the good imported, i.e., there would be slight semantic difference between "Local" and "City" causing evaluation to be against different city in some cases.

As the ruleset loading time checks guard against ever getting Good requirement with "Local" range, resolving this issue is not urgent, end especially a solution where the functionality gets extended can only occur in later branches that are not yet d3f.

Ticket-Verlauf (3/6 Historien)

2021-10-07 17:30 Aktualisiert von: cazfi
  • New Ticket "Inconsistent code about "Local" range "Good" reqs" created
2022-08-22 04:17 Aktualisiert von: cazfi
2022-08-22 16:24 Aktualisiert von: alienvalkyrie
Kommentar

Note that all non-d3f branches (i.e. currently only master) have had any functionality such as what is described above moved out of the "Local" range into the new "Tile" range.

2022-10-07 09:18 Aktualisiert von: cazfi
2022-12-08 16:18 Aktualisiert von: cazfi
2023-01-31 11:17 Aktualisiert von: cazfi

Dateianhangliste

Keine Anhänge

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden