wrong help text for the trade_revenue_style server option

• Auswertung: log65536
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: Documentation
• Meilenstein: 3.0.0 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details Antworten

Attempting my first patch for Freeciv, a simple one to get used to the workflow. Please tell me if something is not in line with recommended practice and I'll do it better next time.

Ticket-Verlauf (3/7 Historien)

2021-10-01 07:19 Aktualisiert von: log65536

• New Ticket "wrong help text for the trade_revenue_style server option" created

2021-10-01 07:19 Aktualisiert von: log65536

• File 0001-Fix-help-text-for-the-trade_revenue_style-server-opt.patch (File ID: 7571) is attached

2021-10-01 07:20 Aktualisiert von: log65536

• File 0001-Fix-help-text-for-the-trade_revenue_style-server-opt.patch (File ID: 7571) is deleted

2021-10-01 07:20 Aktualisiert von: log65536

• File 0001-Fix-help-text-for-the-trade_revenue_style-server-opt.patch (File ID: 7572) is attached

2021-10-01 07:23 Aktualisiert von: log65536

• Komponente Update from (Keine) to Documentation

2021-10-01 08:39 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted
• Meilenstein Update from (Keine) to 3.0.0 (closed)

Kommentar Antworten

Patch seems perfect to me.

Workflow note about what happens next: As osdn does not have a ticket state "In Testing" / "In Review", or anything like that, we use "Accepted" (which we have no other use for) to mark patch that has entered public review period, minimum of 36h. In this case we have the 3.0.0-beta3 release coming in a week, and as this 1) is not a regression since beta2 2) introduces translatable string change, we're unlikely to push it in last minute but rather wait until beta3 is out.

2021-10-09 01:36 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt