OSX randseed.c compilation failing

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: Bootstrap
• Meilenstein: 2.6.5 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

Seen on CI, OSX build fails:

--

../../utility/randseed.c:60:7: error: implicit declaration of function 'getentropy' is invalid in C99 -Werror,-Wimplicit-function-declaration

if (getentropy(&seed, sizeof(seed)) == 0) {

--

Configure check for both sys/random.h header and getentropy() existence success. The likely cause of the failure is that AC_CHECK_HEADER() does not, unlike AC_CHECK_HEADERS(), define the HAVE_xxx macro by itself.

Ticket-Verlauf (3/5 Historien)

2021-04-14 19:33 Aktualisiert von: cazfi

• New Ticket "OSX randseed.c compilation failing" created

2021-04-14 19:56 Aktualisiert von: cazfi

Kommentar

Check for bcrypt.h has been similarly changed from being part of AC_CHECK_HEADERS() to AC_CHECK_HEADER() and macro HAVE_BCRYPT_H is expected in randseed.c.

2021-04-14 20:07 Aktualisiert von: cazfi

• File 0050-Use-AC_CHECK_HEADERS-when-HAVE_xxx_H-macro-expected.patch (File ID: 6525) is attached

2021-04-14 20:08 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

Kommentar

- Will push attached patch to master immediately. If CI then indicates that it fixes the OSX issue, will push also to other branches.

2021-04-14 20:25 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt

Kommentar

Now pushed to all branches.