Ticket #41992

Document what 'disabled' means in an enabler

Eröffnet am: 2021-04-12 18:38 Letztes Update: 2021-05-05 17:17

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Accepted
Datei:
1

Details

Document what the disabled field in an action enabler is for.

Ticket-Verlauf (3/6 Historien)

2021-04-12 18:38 Aktualisiert von: kvilhaugsvik
  • New Ticket "Document what 'disabled' means in an enabler" created
2021-04-12 18:48 Aktualisiert von: kvilhaugsvik
2021-04-16 16:39 Aktualisiert von: kvilhaugsvik
  • Status Update from Offen to Geschlossen
2021-05-04 17:37 Aktualisiert von: cazfi
Kommentar

I'm not sure if the text added here is correct or wrong, but based on it I assumed enabler.disabled to act like .ruledit_disabled for other structs. It does not, but also ruleset loading (both ruleset.c and rscompat.c) may set it in addition to ruledit.

Are these ruleset loading time disabled enablers still used at game run time? (the comment added here claims that only rulesave cares about 'disabled'). For the other 'ruledit_disabled' the logic is that they are ever set only inside ruledit - never when actually running the game, and thus we don't need to check against it at game run time (standard iterations do not).

2021-05-05 17:17 Aktualisiert von: None
Kommentar

Reply To cazfi

I'm not sure if the text added here is correct or wrong, but based on it I assumed enabler.disabled to act like .ruledit_disabled for other structs. It does not, but also ruleset loading (both ruleset.c and rscompat.c) may set it in addition to ruledit.

Ruleset loading will only set it in compatibility mode and when purging(/cleaning) unused entities, so it should be ruledit and freeciv-ruleup only. That is unless someone added support for playing rulesets from the previous version to the server while I didn't pay attention.

Are these ruleset loading time disabled enablers still used at game run time?

I could add a step that deletes them if you have plans to add ruleset compatibility and/or purging support to the server.

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden