Ticket #41884

convert_png update for modern inkscape

Eröffnet am: 2021-03-30 20:55 Letztes Update: 2021-04-14 22:21

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
2

Details

Current inkscape version does not understand the parameters convert_png tries to pass it. Update convert_png.

Ticket-Verlauf (3/11 Historien)

2021-03-30 20:55 Aktualisiert von: cazfi
  • New Ticket "convert_png update for modern inkscape" created
2021-03-31 18:42 Aktualisiert von: cazfi
Kommentar

I have Inkscape 1.0.2

2021-04-03 14:14 Aktualisiert von: cazfi
  • Lösung Update from Keine to Accepted
2021-04-10 21:59 Aktualisiert von: cazfi
  • Lösung Update from Accepted to Keine
Kommentar

Images do not scale correctly with this.

2021-04-10 22:36 Aktualisiert von: cazfi
Kommentar

The scaling seems to work, after all. There is some other trouble with, e.g., persian (iran_ancient) flag.

2021-04-10 22:42 Aktualisiert von: cazfi
Kommentar

It has page bigger than the actual image -> #41966

There are other flags with (supposedly) same problem.

2021-04-11 01:17 Aktualisiert von: cazfi
Kommentar

As this patch updates only the conversion script, without regenerating all the flag pngs with it (and we can't regenerate all of them for the issues we see with some of them), this means we are about to ship pngs for which we provide no tool by which they were generated. Also, until this patch is applied, regenerating some of the pngs in other tickets, using the new script that works with current inkscape, again leads to shipping pngs for which we provide no tool by which they were generated.

As a solution I think we need to temporarily ship both tool versions. Make a copy of old convert_png as convert_png_legacy, and update convert_png.

2021-04-13 03:56 Aktualisiert von: cazfi
  • Lösung Update from Keine to Accepted
Kommentar

- Add convert_png_legacy

2021-04-14 22:21 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Accepted to Gefixt

Bearbeiten

Please login to add comment to this ticket » Anmelden