civ2 ruleset has two Establish Embassy move costs

• Auswertung: cazfi
• Verantwortlicher: kvilhaugsvik
• Typ: Fehler
• Status: Geschlossen
• Komponente: Rulesets
• Meilenstein: 3.1.0 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

master civ2 ruleset:

effect_action_success_move_cost_embassy -> Action_Success_Actor_Move_Cost with value 1 for action Establish Embassy

effect_action_success_establish_embassy -> Action_Success_Actor_Move_Cost with value 65535 for action Establish Embassy

Together these make 65536.

Ticket-Verlauf (3/8 Historien)

2021-03-13 19:57 Aktualisiert von: cazfi

• New Ticket "civ2 ruleset has two Establish Embassy move costs" created

2021-03-13 20:14 Aktualisiert von: kvilhaugsvik

Kommentar

Looks like moving two different hard coded move cost to the ruleset on two different occasions. 65535 means "everything".

I could merge them (and probably other rulesets with the same problem) to a single effect with a value of 65535

2021-03-15 06:12 Aktualisiert von: kvilhaugsvik

Kommentar

Is it OK if I take this?

2021-03-15 06:24 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to kvilhaugsvik

Kommentar

Reply To kvilhaugsvik

Is it OK if I take this?

That's why I have left it unassigned.

2021-03-15 20:38 Aktualisiert von: kvilhaugsvik

• File 0001-Deduplicate-Establish-Embassy-move-costs.patch (File ID: 6273) is attached

2021-03-15 20:38 Aktualisiert von: kvilhaugsvik

• Lösung Update from Keine to Accepted
• Meilenstein Update from (Keine) to 3.1.0 (closed)

2021-03-17 13:40 Aktualisiert von: kvilhaugsvik

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt

2021-03-19 15:58 Aktualisiert von: kvilhaugsvik

Kommentar

Reply To kvilhaugsvik

Looks like moving two different hard coded move cost to the ruleset on two different occasions.

But a bug because Establish Embassy doesn't result in spy escape. See #41811