#45716: generate_packets.py: Replace unfill with bit-copy/move
Open Date: 2022-09-25 15:57
Last Update: 2022-09-28 15:25
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45716
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45716
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-09-28 15:25 Updated by: alienvalkyrie
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: alienvalkyrie
Owner: alienvalkyrie
Type: Patches
Status: Closed
Priority: 5 - Medium
MileStone: 3.2.0
Component: Bootstrap
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
Part of #43927. The unfill concept introduced in #45222 as a mirror to fill is ultimately misguided; the actual use case is backing up the received key fields while zeroing a packet struct (to initialize the cache), which amounts to temporarily moving those values out of the struct – this is better achieved by bitcopying the data, i.e. a straight assignment (for non-arrays at least). In contrast, fill clones the data, which is not what we want here (and which could cause problems if and when we start to support types that need to be destroyed explicitly).
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45716
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45716