#45572: Unit requirements vector freed only when unit has helptext
Open Date: 2022-09-05 00:09
Last Update: 2022-09-17 10:43
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45572
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45572
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-09-17 10:43 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.1.0
Component: General
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
unit_type_free() does requirement_vector_free(&(punittype->build_reqs)); within a "if (NULL != punittype->helptext) {" -block. So the requirement vector is not freed if the unit has no hand-written helptext.
I found this when I were looking if a bug could be explained by some unit requirements from earlier rulesets leaking to a newly loaded one. Not sure if this one could have such an effect.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45572
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45572