#44167: mapgen: Phase out direct references to alltemperate and single_pole
Open Date: 2022-03-23 15:06
Last Update: 2022-03-23 22:16
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44167
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44167
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-03-23 22:16 Updated by: alienvalkyrie
Comment:
Reply To alienvalkyrie
Regression test failed with multiplayer ruleset; presumably the patch has some unintended impact on alltemperate maps.
Found the issue: The generalization of the code that used to halve the ICE_BASE_LEVEL on singlepole maps now scales it to the latitude range, which means it becomes zero on alltemperate maps. While that shouldn't, conceptually speaking, make a difference (since no tile's actual latitude is remotely close to it), the ICE_BASE_LEVEL is used in mapgen.c:adjust_terrain_param() to affect various terrain percentages.
This also reveals an underlying issue, namely that (prior to this change) singlepole affects alltemperate maps ~> #44174
I don't think it's worth adding special cases just to avoid this change; I will however change aforementioned code either way, since scaling down ICE_BASE_LEVEL indefinitely actually doesn't sound sensible (particularly for future maps covering less than an entire hemisphere – players might want larger polar areas there).
---------------------------------------------------------------------
Ticket Status:
Reporter: alienvalkyrie
Owner: alienvalkyrie
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.2.0
Component: Server
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Required for #44038. This is the mapgen part of #44166 and should use the macros defined there.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44167
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44167