#44019: city_size_add(): Use 'size' variable
Open Date: 2022-03-04 09:35
Last Update: 2022-03-04 09:35
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44019
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44019
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-03-04 09:35 Updated by: cazfi
* New Ticket "city_size_add(): Use 'size' variable" created
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: 3.0.1
Component: General
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
city_size_add() assigns city size to a variable, but then calls city_size_get() again when it needs it. Use the variable instead. This is a really minor optimization, but more importantly it helps in getting rid compiler warning in NDEBUG build; currently 'size' is a set but unused variable outside fc_assert().
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44019
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44019