#44882: citizenshand.c doing useless work when FREECIV_DEBUG not set
Open Date: 2022-06-20 17:00
Last Update: 2022-06-22 19:29
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44882
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44882
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-06-22 19:29 Updated by: cazfi
* Priority Update from 5 - Medium to 9 - Highest
Comment:
Reply To cazfi
../../../src/server/citizenshand.c:159:18: warning: variable 'pplayer' set but not used [-Wunused-but-set-variable!]
That's a build failure on CI now. To be resolved as an emergency fix.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 9 - Highest
MileStone: (None)
Component: Server
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
../../../src/server/citizenshand.c:159:18: warning: variable 'pplayer' set but not used [-Wunused-but-set-variable!]
That's basically because pplayer would only be used in log_citizens(), which currently is defined as log_debug(), which expands to nothing when FREECIV_DEBUG is not set.
Ideally the fix would support changing log_citizens() to be something else than log_debug()
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44882
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44882