[Freeciv-tickets] [freeciv] #44778: Resolve script dangers around unit_change_owner()

Zurück zum Archiv-Index
OSDN Ticket System norep****@osdn*****
Fri Jun 10 06:46:23 JST 2022


#44778: Resolve script dangers around unit_change_owner()

  Open Date: 2022-06-08 09:48
Last Update: 2022-06-10 00:46

URL for this Ticket:
    https://osdn.net//projects/freeciv/ticket/44778
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44778

---------------------------------------------------------------------

Last Changes/Comment on this Ticket:
2022-06-10 00:46 Updated by: ihnatus

Comment:

A 3.0 patch is ready, it works for simple cases, though really nasty callbacks I could write still fail due to code out of scope (specifically, clearing of vision in server_remove_unit() before calling a callback that makes it not recursive); some changes done in previous patches in HRM849859 and #44312 are needed for it but the patches theselves should be modified to apply over or beneath this one.

---------------------------------------------------------------------
Ticket Status:

      Reporter: ihnatus
         Owner: (None)
          Type: Bugs
        Status: Open
      Priority: 5 - Medium
     MileStone: (None)
     Component: Server
      Severity: 5 - Medium
    Resolution: None
---------------------------------------------------------------------

Ticket details:

A split of #44738.
It should be handled that this function sometimes does not give out a unit due to the callback in wipe_init(). In do_capture_units() stack iteration must be safe. Also, in diplomat_bribe() we should avoid getting into negative gold (what's the alternative?..)

-- 
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN

Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net

URL for this Ticket:
    https://osdn.net/projects/freeciv/ticket/44778
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44778



More information about the Freeciv-tickets mailing list
Zurück zum Archiv-Index