#45035: sdl2: create_select_tech_icon() surface leak
Open Date: 2022-07-06 11:35
Last Update: 2022-07-16 15:45
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45035
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45035
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-07-16 15:45 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
* Milestone Update from (None) to 3.0.3
Comment:
S3_0 patch to be applied to S2_6 too
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.3
Component: SDL2-client
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
create_select_tech_icon() creates temporary surfaces with adj_surf() from unittype surfaces. These are never freed.
Note the difference between sdl- and sdl2-client adj_surf() - sdl2-client one always creates a completely new surface, sdl-client does not. So I assume this is sdl2-client only bug, and freeing the returned surface in sdl-client would actually result in double free.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45035
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45035