#45059: "pdcity->identity == pcity->id" assert failure when unit moves
Open Date: 2022-07-08 04:40
Last Update: 2022-07-08 04:40
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45059
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45059
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-07-08 04:40 Updated by: cazfi
* New Ticket ""pdcity->identity == pcity->id" assert failure when unit moves" created
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: (None)
Component: Server
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
This happened on heavily patches master autogame, but the bug seems like something that would be present in the mainline too (at least in master, possibly also in older branches)
Assert 'pdcity->identiry == pcity->id' from update_dumb_city() failed. This was called from refresh_dumb_city() itself called from unit_move(). The update_dumb_city() header specifically says: "If the player_tile already contains a city it must be the same city (avoid problems by always calling reality_check_city() first)"
I see no reason to assume that the city unit_move() reveals is the same as one in the player_tile (city earlier seen on the same tile - possibly then destroyed) nor does it seem to take any action to handle the situation (namely: there's no reality_check_city() call suggested by update_dumb_city() header)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45059
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45059