#44993: generate_packets.py: use FC_FREE macro
Open Date: 2022-07-03 17:08
Last Update: 2022-07-03 19:26
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44993
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44993
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-07-03 19:26 Updated by: alienvalkyrie
* Resolution Update from None to Accepted
* Type Update from Bugs to Patches
Comment:
The mentioned special case is nontrivial to work with, so I'll make a separate ticket for that.
---------------------------------------------------------------------
Ticket Status:
Reporter: alienvalkyrie
Owner: alienvalkyrie
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.2.0
Component: Bootstrap
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
Split from discussion in #44977; related to hrm#745593.
Reply To cazfi
... change to use FC_FREE() instead of free() + "... = NULL;" for some fields. Not sure if we want to do that, but if we do, it should go to separate ticket and then handle also other similar cases in generate_packets.py.
There are currently 13 such cases, as well as one use of free() without ... = NULL; (which would cause problems if there were any packets with both pre-send and post-send hooks).
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44993
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44993