#44977: generate_packets.py: indent generated code only once needed
Open Date: 2022-07-02 00:03
Last Update: 2022-07-03 16:07
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44977
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44977
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-07-03 16:07 Updated by: cazfi
Comment:
Reply To alienvalkyrie
Note: This change is going to conflict with parts of hrm#745593 (by changing the indentation of code modified there). Need to figure out whether to delay this until after that, or whether that needs more changes that take longer anyway.
One thing still in hrm#745593 touching generate_packets.py, and not related to the main issue of that ticket are the change to use FC_FREE() instead of free() + "... = NULL;" for some fields. Not sure if we want to do that, but if we do, it should go to separate ticket and then handle also other similar cases in generate_packets.py.
---------------------------------------------------------------------
Ticket Status:
Reporter: alienvalkyrie
Owner: alienvalkyrie
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.2.0
Component: Bootstrap
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Part of #43927. To make code-generating functions more reusable, each function should produce code that is as un-indented as possible, with callers using prefix() to indent as necessary; this way, the generated code can easily be used in different contexts where it needs different indentation.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44977
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44977