#43745: generate_packets.py minimum Python version
Open Date: 2022-01-30 21:09
Last Update: 2022-02-19 01:38
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/43745
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43745
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-02-19 01:38 Updated by: alienvalkyrie
* Resolution Update from None to Accepted
Comment:
Reply To cazfi
Consider this a security issue - the update might be a fix to a vulnerability.
Good call; that's the point I figured must exist, but couldn't quite put my finger on.
S3_0 patch that just changes the comment is attached.
---------------------------------------------------------------------
Ticket Status:
Reporter: alienvalkyrie
Owner: alienvalkyrie
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.1
Component: General
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
The comment in common/generate_packets.py claims it's compatible with every Python version since 1.5, and says to keep it that way; in particular, not to replace string.join calls. The update to make the script Python-3-compatible did just that.
Clearly, the script is not 1.5-compatible anymore (nor does it need to). Given the use of a python3 executable, our minimum supported version is in the Python 3 range – we should figure out / decide what specific version we want that to be, and update the comment accordingly.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/43745
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43745