#43563: Relative frequency of resources Open Date: 2022-01-06 13:54 Last Update: 2022-02-01 20:01 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/43563 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43563 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-02-01 20:01 Updated by: alienvalkyrie Comment: Reply To cazfi Reply To alienvalkyrie I also don't know how pressing this is, given that relative generation frequencies aren't that relevant during gameplay. I don't think it's that important information for the player. Even if some ruleset makes it important, they can then also tell the frequencies in the hand-written part. I wouldn't consider lack of the autogenerated help as blocker for this ticket. I did think about at least adding the frequencies to civmanual (since knowing about them might be a bit more useful outside/before a game), but I couldn't find a simple way to do it that is also clearly understandable. Should we raise another ticket for this issue specifically? I can't exactly see this happening without a more general change to some of the help dialog / manual structure (cf. aforementioned issue of GTK+ clients putting all resources in one box). For the future commit messages: when you (the author as listed by git) are not the one who requested the change or reported the issue, give credit in the commit message (we will collect that information to http:/www.freeciv.org/wiki/People mostly from the commit messages as part of the release process). No need to resubmit this one - I've modified the commit message in my own tree (and currently assuming I will be the one pushing the patch) Noted. I also noticed I put the TODO in a /* ... */ comment in C++ code (QT client helpdlg) rather than a // .... Another thing I had been thinking about was to replace replace all loops with the terrain_resources_iterate macro, but without code that uses the frequencies, I'm not sure it makes much of a difference (apart from introducing a yet-unused variable), so it's probably not worth submitting a new patch for. --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Patches Status: Open Priority: 5 - Medium MileStone: S3_2 d3f Component: General Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: Like XYZ says in http://forum.freeciv.org/f/viewtopic.php?f=13&t=92129 , it would be good to be able to define that some resources are more rare than others. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/43563 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43563