#43207: Rename ACTION_STARTED_... as ACTION_PERFORM_...
Open Date: 2021-11-13 14:53
Last Update: 2021-11-13 14:59
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/43207
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43207
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2021-11-13 14:59 Updated by: cazfi
* Resolution Update from None to Accepted
* Milestone Update from (None) to 3.1.0
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: 3.1.0
Component: Server
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
ACTION_STARTED_... macros actually are *not* only about starting the action, but about performing it in full (all the way of paying movement costs etc *after* the action). Rename them accordingly as ACTION_PERFORM_...
This came up as I looked up where to add emitting signal for *ending* the action (https://www.hostedredmine.com/issues/817749). Turns out it's place is would be within the _STARTED_ macro.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/43207
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43207